Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command 'gcp verify wif-config' #691

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add command 'gcp verify wif-config' #691

merged 1 commit into from
Dec 5, 2024

Conversation

JakobGray
Copy link
Contributor

@JakobGray JakobGray commented Dec 3, 2024 •
edited
Loading

Issue: https://issues.redhat.com/browse/OCM-12286

➜  ocm gcp verify wif-config -h
Verify a workload identity federation configuration (wif-config) object.

Usage:
  ocm gcp verify wif-config [ID|Name] [flags]

Flags:
  -h, --help   help for wif-config

➜  ocm gcp list wif-configs                                                           
ID                                DISPLAY NAME  PROJECT ID
2fdn79v1eg7btv5qlakanc4sq8917ut6  jdg           sda-ccs-1 

# Verify wif-config - passes
➜  ocm gcp verify wif-config jdg
WIF configuration is valid

# Modified wif-config (role removed from service account jdg-gcp-pd-csi-driver-op-7ut6) - fails
➜  ocm gcp verify wif-config jdg
Error: verification failed with error: missing role 'compute.storageAdmin'
Running 'ocm gcp update wif-config' may fix errors related to cloud resource misconfiguration.
exit status 1

# Self repair
➜  ocm gcp update wif-config jdg

# Verify again - passes
➜  ocm gcp verify wif-config jdg
WIF configuration is valid

@ckandag ckandag self-requested a review December 4, 2024 22:41
@renan-campos renan-campos merged commit 1bafd65 into openshift-online:main Dec 5, 2024
4 of 5 checks passed
@JakobGray JakobGray deleted the OCM-12286 branch December 5, 2024 16:38
ckandag added a commit that referenced this pull request Dec 6, 2024
@ckandag
Release v1.0.3
74e6544 
-9fbb753 Update to use addon service API for addons function
-1bafd65 Add command 'gcp verify wif-config' (#691)
-5d0bec1 Update Konflux references (#682)
ckandag added a commit that referenced this pull request Dec 6, 2024
@ckandag
Release v1.0.3
82caa23 
-9fbb753 Update to use addon service API for addons function
-1bafd65 Add command 'gcp verify wif-config' (#691)
-5d0bec1 Update Konflux references (#682)
@ckandag ckandag mentioned this pull request Dec 6, 2024
Closed
ckandag added a commit that referenced this pull request Dec 9, 2024
@ckandag
Release v1.0.3
588efdb 
-9fbb753 Update to use addon service API for addons function
-1bafd65 Add command 'gcp verify wif-config' (#691)
-5d0bec1 Update Konflux references (#682)
-f0ed911 OCM-12467 | feat : Updates for binaries-release-pipeline (#693)
-c42c641 Update Konflux references (#694)
ckandag added a commit that referenced this pull request Dec 9, 2024
@ckandag
Release v1.0.3
0855b33 
-9fbb753 Update to use addon service API for addons function
-1bafd65 Add command 'gcp verify wif-config' (#691)
-5d0bec1 Update Konflux references (#682)
-f0ed911 OCM-12467 | feat : Updates for binaries-release-pipeline (#693)
-c42c641 Update Konflux references (#694)
@ckandag ckandag mentioned this pull request Dec 9, 2024
Merged
renan-campos pushed a commit that referenced this pull request Dec 9, 2024
@ckandag
Release v1.0.3 (#695)
7f8095b 
-9fbb753 Update to use addon service API for addons function
-1bafd65 Add command 'gcp verify wif-config' (#691)
-5d0bec1 Update Konflux references (#682)
-f0ed911 OCM-12467 | feat : Updates for binaries-release-pipeline (#693)
-c42c641 Update Konflux references (#694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckandag ckandag ckandag approved these changes

@renan-campos renan-campos renan-campos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakobGray @renan-campos @ckandag